Skip to content

Fix undefined behavior in U/INT8 in L2_SVE [MOD-9080] #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Fix undefined behavior in U/INT8 in L2_SVE [MOD-9080] #681

merged 1 commit into from
May 26, 2025
+3 −2

Conversation

lerman25
Copy link
Collaborator

@lerman25 lerman25 commented May 26, 2025 •
edited
Loading

Previously, we sum onto sum3 without active lanes selection because svld1 load zeros onto inactive lanes,
but in abs_diff we use svabd_s8_x and the same pg so the inactive lanes will be arbitrary rather than 0, which is a mistake.
This PR changes the lanes in svabd from pg to all.

@lerman25 lerman25 requested a review from GuyAv46 May 26, 2025 08:23
@lerman25 lerman25 marked this pull request as draft May 26, 2025 09:27
@lerman25 lerman25 marked this pull request as ready for review May 26, 2025 09:27
@lerman25 lerman25 enabled auto-merge May 26, 2025 09:27
@lerman25 lerman25 marked this pull request as draft May 26, 2025 09:32
auto-merge was automatically disabled May 26, 2025 09:32

Pull request was converted to draft

@lerman25 lerman25 marked this pull request as ready for review May 26, 2025 09:32
@lerman25 lerman25 enabled auto-merge May 26, 2025 09:54
@codecov Codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (aabfdda) to head (046fff4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         112      112           
  Lines        6278     6278           
=======================================
  Hits         6042     6042           
  Misses        236      236

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lerman25 lerman25 added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit 552b295 May 26, 2025
35 of 47 checks passed
@lerman25 lerman25 deleted the omer-fix-undefined-SVE branch May 26, 2025 11:53
github-actions bot pushed a commit that referenced this pull request May 26, 2025
@lerman25 @github-actions
Fix undefined behavior in U/INT8 in L2_SVE [MOD-9080] (#681)
419f593 
Change pg to all

(cherry picked from commit 552b295)
@github-actions GitHub Actions
Copy link

Successfully created backport PR for 8.0:

@github-actions github-actions bot mentioned this pull request May 26, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 26, 2025
@github-actions @lerman25
[8.0] Fix undefined behavior in U/INT8 in L2_SVE [MOD-9080] (#682)
19177e6 
Fix undefined behavior in U/INT8 in L2_SVE [MOD-9080] (#681)

Change pg to all

(cherry picked from commit 552b295)

Co-authored-by: lerman25 <58445352+lerman25@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyAv46 GuyAv46 GuyAv46 approved these changes

Assignees
No one assigned
Labels
backport 8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lerman25 @GuyAv46